Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CircleCI config #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielcompton
Copy link
Contributor

@danielcompton danielcompton commented Jun 19, 2019

This is not a very sophisticated build system, but it does get the ball rolling for adding testing for more of the projects.

I had to include #85 in this branch as the bin/eftest script is broken on master (thanks to me).

@SevereOverfl0w
Copy link
Contributor

I'm going to think about this one a little. While I want to have CI for Edge, I want to make sure this doesn't make it harder for users to use circle ci themselves.

For example if someone scraps this file and starts over in their repo, what happens with git conflicts? I think git does the right thing (oh, you deleted it back their, so discard conflicts on this file). But I want to make sure.

Ideally this would be something that users could build upon. For example, I love the aggregate deps.edn cache, that's a great thing to reuse! Although, it doesn't do clj for all those deps.edn files, so the .m2 folder will probably need some additional population first.

@danielcompton
Copy link
Contributor Author

danielcompton commented Jun 20, 2019

For example if someone scraps this file and starts over in their repo, what happens with git conflicts? I think git does the right thing (oh, you deleted it back their, so discard conflicts on this file). But I want to make sure.

This is a good point, I hadn't considered this.

Although, it doesn't do clj for all those deps.edn files, so the .m2 folder will probably need some additional population first.

My approach in the past when using Leiningen with CI testing has been to just let the test runners populate the ~/.m2 cache. The boot time to download the dependencies was sometimes quite slow, and often there were dynamic dependencies added after the fact anyway.

Using clj, you don't have as much boot time, so it should be fine to download the dependencies in a separate step. However we still add eftest as a dynamic dependency in the script. I'm not sure how much it buys you pre-downloading the artifacts, but I don't really mind either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants